[PATCH v4] MIPS: Sync elf.h from binutils

Maciej W. Rozycki macro@orcam.me.uk
Tue Jun 6 16:26:08 GMT 2023


Hi Ying,

> OK. And I have a question, can I use space+tab combination when aligned?

 If you mean a sequence of one or more of spaces immediately followed by 
one or more tabs, than this is not allowed by the GNU Coding Standards.

> Because when I only use tab to align, it occurs:
> 
> Vim open file shows alignment, but git diff show not alignment.

 Note that the leading plus/minus/space character in a unidiff will affect 
how columns are aligned where tabs are used and is sometimes a cause for 
confusion, especially when hand-editing patches.  Just ignore that.  It's 
the formatting of the actual file that matters.

 NB I have:

core.whitespace=indent-with-non-tab,space-before-tab,trailing-space

set in my git configuration for GNU toolchain repos, which helps identify 
some of these issues.  You may still have to double-check your result, as 
these automatic checks are not completely fool-proof.

 HTH,

  Maciej


More information about the Libc-alpha mailing list