[PATCH v1] stdlib: Fixup mbstowcs NULL __dst handling.
Siddhesh Poyarekar
siddhesh@gotplt.org
Thu Jun 23 14:26:56 GMT 2022
On 23/06/2022 11:16, Siddhesh Poyarekar wrote:
> On 23/06/2022 05:04, Noah Goldstein via Libc-alpha wrote:
>> commit 464d189b9622932a75302290625de84931656ec0 (origin/master,
>> origin/HEAD)
>> Author: Noah Goldstein <goldstein.w.n@gmail.com>
>> Date: Wed Jun 22 08:24:21 2022 -0700
>>
>> stdlib: Remove attr_write from mbstows if dst is NULL [BZ: 29265]
>>
>> Incorrectly called `__mbstowcs_chk` in the NULL __dst case which is
>> incorrect as in the NULL __dst case we are explicitly skipping
>> the objsize checks.
>>
>> As well, remove the `__always_inline` attribute which exists in
>> `__fortify_function`.
>> ---
>> stdlib/bits/stdlib.h | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> LGTM.
>
> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Please add a reference to bz #29279 in the commit log when you push this.
Sid
More information about the Libc-alpha
mailing list