[PATCH] Properly check linker option in LIBC_LINKER_FEATURE [BZ #28738]

Florian Weimer fweimer@redhat.com
Tue Jan 4 21:47:51 GMT 2022


* Joseph Myers:

> On Sun, 2 Jan 2022, H.J. Lu via Libc-alpha wrote:
>
>> +    if ${CC-cc} $CFLAGS $CPPFLAGS $LDFLAGS $no_ssp $2 -nostdlib \
>> +	-nostartfiles -fPIC -shared -o conftest.so conftest.c 2>&1 \
>> +	| grep "warning: $1 ignored" > /dev/null 2>&1; then
>
> If you check for specific English language text like that (which may not 
> be a good idea, since binutils maintainers may expect to be able to 
> rephrase messages without breaking glibc), you need to run the linker (and 
> thus the compiler) with LC_ALL=C to avoid getting a translated message.

That was my thought as well, but I think the generated configure script
already takes care of that:

# NLS nuisances.
LC_ALL=C
export LC_ALL
LANGUAGE=C
export LANGUAGE

That's fairly early in the script.

Thanks,
Florian



More information about the Libc-alpha mailing list