[PATCH] Set LC_ALL=C for LIBC_LINKER_FEATURE [BZ #28738]

[H.J. Lu]

On Tue, Jan 4, 2022 at 10:37 AM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Sun, 2 Jan 2022, H.J. Lu via Libc-alpha wrote:
>
> > +    if ${CC-cc} $CFLAGS $CPPFLAGS $LDFLAGS $no_ssp $2 -nostdlib \
> > +     -nostartfiles -fPIC -shared -o conftest.so conftest.c 2>&1 \
> > +     | grep "warning: $1 ignored" > /dev/null 2>&1; then
>
> If you check for specific English language text like that (which may not
> be a good idea, since binutils maintainers may expect to be able to

True.  Different linkers can have different behavior on unknown
options.   We need to update the linker feature check for it.

> rephrase messages without breaking glibc), you need to run the linker (and
> thus the compiler) with LC_ALL=C to avoid getting a translated message.
>

Here is a patch to set LC_ALL=C for LIBC_LINKER_FEATURE.

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Set-LC_ALL-C-for-LIBC_LINKER_FEATURE-BZ-28738.patch
Type: text/x-patch
Size: 2828 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20220104/5fee084d/attachment.bin>