[PATCH 1/2] LoongArch: Fix ptr mangling/demangling features.

caiyinyu caiyinyu@loongson.cn
Fri Aug 26 02:44:50 GMT 2022


How about using this patch[1] now to fix this build error first?

[1] https://sourceware.org/pipermail/libc-alpha/2022-August/141489.html

There is no modify in common files and all happy besides performance 
overhead

of one more instruction.


在 2022/8/26 上午1:01, Adhemerval Zanella Netto 写道:
>
> On 25/08/22 12:27, Xi Ruoyao wrote:
>> On Thu, 2022-08-25 at 12:08 -0300, Adhemerval Zanella Netto wrote:
>>> Does is really pay off the complexity to use HAVE_LOONGARCH_EXPLICIT_RELOCS? The
>>> PTR_MANGLE is used some specific cases and hardly a hotstop.
>> LDST_PCREL added as a macro in sysdep.h, so further assembly
>> implementations might reuse it then it may appear in some hot spot.
>>
>> If we quote "optimization too early is the ultimate evil", we can drop
>> it for now and review once we use LDST_PCREL somewhere else. But to me
>> this is rather a simple autoconf check and I can't figure out a
>> situation where it's evil...
> It is more that configure checks might create maintainability burden or just
> dead code in the long term, specially where it does have a fallback that works
> with no much performance penalty.



More information about the Libc-alpha mailing list