[PATCH 1/2] LoongArch: Fix ptr mangling/demangling features.
Adhemerval Zanella Netto
adhemerval.zanella@linaro.org
Thu Aug 25 17:01:00 GMT 2022
On 25/08/22 12:27, Xi Ruoyao wrote:
> On Thu, 2022-08-25 at 12:08 -0300, Adhemerval Zanella Netto wrote:
>> Does is really pay off the complexity to use HAVE_LOONGARCH_EXPLICIT_RELOCS? The
>> PTR_MANGLE is used some specific cases and hardly a hotstop.
>
> LDST_PCREL added as a macro in sysdep.h, so further assembly
> implementations might reuse it then it may appear in some hot spot.
>
> If we quote "optimization too early is the ultimate evil", we can drop
> it for now and review once we use LDST_PCREL somewhere else. But to me
> this is rather a simple autoconf check and I can't figure out a
> situation where it's evil...
It is more that configure checks might create maintainability burden or just
dead code in the long term, specially where it does have a fallback that works
with no much performance penalty.
More information about the Libc-alpha
mailing list