[PATCH] elf: Remove -fno-tree-loop-distribute-patterns usage on dl-support

Adhemerval Zanella Netto adhemerval.zanella@linaro.org
Wed Aug 10 13:04:06 GMT 2022



On 10/08/22 00:37, Noah Goldstein wrote:
>>  #endif
>> diff --git a/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S
>> index ac4b2d2d50..034d19b35e 100644
>> --- a/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S
>> +++ b/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S
>> @@ -44,4 +44,7 @@
>>
>>  # define USE_LESS_VEC_MASK_STORE       1
>>  # include "memset-vec-unaligned-erms.S"
>> +# if !defined NO_MULTIARCH && MINIMUM_X86_ISA_LEVEL >= 4
>> +strong_alias (__memset_evex_unaligned, __memset_generic)
>> +# endif
> 
> Instead of adding aliases in each file can't you just add one alias
> at the end of multiarch/rtld-memset.S?
> 
> Might be cleaner. Generally prefer keeping all the alias stuff
> out of the implementation files if possible.

The problem is not really the loader since we do not support calling ifunc
from it (that's why multiple ports have rtld-* overrides), the issue is the
initialization for static where either functions call are not possible 
(dl-tunables.c) or ifunc calls are not possible (dl-support.c).

In any case, I am experiment with H.J. suggestion to alias to a per-arch
symbol instead of add a generic one.


More information about the Libc-alpha mailing list