[RFC PATCH v4 1/2] configure: Remove --enable-obsolete-nsl
Tue Jun 30 17:16:45 GMT 2020
> * Petr Vorel:
> > thank you for your review. I'll have time to send next version in second
> > half of July.
> If we merge new ports for glibc 2.32, it would be nice not include
> sunrpc in them. We'll figure something out.
+1. I'll try to send v5 tonight or tomorrow.
> >> > diff --git a/grp/initgroups.c b/grp/initgroups.c
> >> > index f4c4e986e9..0c17141117 100644
> >> > --- a/grp/initgroups.c
> >> > +++ b/grp/initgroups.c
> >> > @@ -31,12 +31,6 @@
> >> > #include "../nscd/nscd-client.h"
> >> > #include "../nscd/nscd_proto.h"
> >> > -#ifdef LINK_OBSOLETE_NSL
> >> > -# define DEFAULT_CONFIG "compat [NOTFOUND=return] files"
> >> > -#else
> >> > -# define DEFAULT_CONFIG "files"
> >> > -#endif
> >> > -
> >> That looks a bit like a pre-existing bug—we do have nss_compat even
> >> without libnsl. But the change itself looks okay.
> > Hm, I'll have look into it after this patchset is finished, but not sure
> > if I'm able to fix this.
> Sorry, no change to the patch is required. Removing this is fine. We
> shouldn't have had a default that depends on LINK_OBSOLETE_NSL.
> > Hm, libnss_compat is not built (now libnsl is only built as shared
> > library, for platforms where it was supported), so what exactly would
> > you put here?
> nss_compat no longer depends on libnsl in current glibc. It can be used
> without NIS, and some users do that. I don't think your patch changes
Interesting. I guess adding this would be worth then:
libnss_compat no longer depends on libnsl and can be used without NIS.
More information about the Libc-alpha