How to keep Reviewed-by lines in git commits with gerrit.

[Joseph Myers]

On Tue, 12 Nov 2019, Carlos O'Donell wrote:

> In the meantime I can do two things as a reviewer to help you keep
> the Reviewed-by lines.
> 
> 1. If I am about to grant +2 review I edit the commit and generate
>    a new patchset version, and add my Reviewed-by line.
> 2. I submit my review of +2.
> 
> Then when you push, you just need to make sure your new commit message
> matches and it should close the review.

That seems overly complicated.  I thought the Change-Id was how gerrit 
told whether something was the same change, so would have expected that 
simply adding the Reviewed-by to the commit message when doing the final 
commit, but keeping the same Change-Id, would suffice, without extra patch 
set versions being needed unless there is an actual need for a new version 
to be reviewed.

-- 
Joseph S. Myers
joseph@codesourcery.com