How to keep Reviewed-by lines in git commits with gerrit.
Carlos O'Donell
carlos@redhat.com
Tue Nov 12 17:35:00 GMT 2019
Florian,
If we ever switch to supporting Gerrit, then we will automatically
gain the Reviewed-by: lines depending on the configuration of Gerrit.
Reviewers would understand this as part of doing their reviews and
granting the review +1/+2.
In the meantime I can do two things as a reviewer to help you keep
the Reviewed-by lines.
1. If I am about to grant +2 review I edit the commit and generate
a new patchset version, and add my Reviewed-by line.
2. I submit my review of +2.
Then when you push, you just need to make sure your new commit message
matches and it should close the review.
--
Cheers,
Carlos.
More information about the Libc-alpha
mailing list