[PATCH] Fix build warnings in locale/programs/ld-ctype.c

[Stefan Liebler]

On 6/25/19 3:23 PM, Florian Weimer wrote:
> * Stefan Liebler:
> 
>> diff --git a/locale/programs/ld-ctype.c b/locale/programs/ld-ctype.c
>> index e6105928da..cfc9c43fd5 100644
>> --- a/locale/programs/ld-ctype.c
>> +++ b/locale/programs/ld-ctype.c
>> @@ -1396,7 +1396,8 @@ charclass_symbolic_ellipsis (struct linereader *ldfile,
>>   		   (int) (now->val.str.lenmb - (cp - last_str)),
>>   		   from);
>>   
>> -	  get_character (now, charmap, repertoire, &seq, &wch);
>> +	  if (get_character (now, charmap, repertoire, &seq, &wch))
>> +	    goto invalid_range;
> 
> Maybe write:
> 
>    if (get_character (now, charmap, repertoire, &seq, &wch) != 0)
> 
> to match the other function calls?
Okay. That's no problem. If no one opposes, I'll commit the patch 
tomorrow with "!= 0".

Shall I also update the following occurrence in ctype_read?
	      if (ellipsis_token == tok_none)
		{
		  if (get_character (now, charmap, repertoire, &seq, &wch))
		    goto err_label;

> 
> Otherwise, looks good.
> 
> Thanks,
> Florian
>