[PATCH] Fix build warnings in locale/programs/ld-ctype.c
Florian Weimer
fweimer@redhat.com
Tue Jun 25 13:23:00 GMT 2019
* Stefan Liebler:
> diff --git a/locale/programs/ld-ctype.c b/locale/programs/ld-ctype.c
> index e6105928da..cfc9c43fd5 100644
> --- a/locale/programs/ld-ctype.c
> +++ b/locale/programs/ld-ctype.c
> @@ -1396,7 +1396,8 @@ charclass_symbolic_ellipsis (struct linereader *ldfile,
> (int) (now->val.str.lenmb - (cp - last_str)),
> from);
>
> - get_character (now, charmap, repertoire, &seq, &wch);
> + if (get_character (now, charmap, repertoire, &seq, &wch))
> + goto invalid_range;
Maybe write:
if (get_character (now, charmap, repertoire, &seq, &wch) != 0)
to match the other function calls?
Otherwise, looks good.
Thanks,
Florian
More information about the Libc-alpha
mailing list