[PATCH] Makeconfig (ASFLAGS): Always append required assembler flags

Gabriel F. T. Gomes gabriel@inconstante.eti.br
Thu Aug 16 13:00:00 GMT 2018


On Tue, 14 Aug 2018, Florian Weimer wrote:

>On 07/04/2018 04:29 PM, Florian Weimer wrote:
>> Otherwise, it is impossible to set ASFLAGS differently from CFLAGS
>> without also overriding essential flags such as -Wa,--noexecstack.

I understood that this patch will let us set ASFLAGS from the
command-line.  You mentioned CFLAGS because that's how we could indirectly
set ASFLAGS, right?

If so, looks good to me.

>> --- a/Makeconfig
>> +++ b/Makeconfig
>> @@ -1047,7 +1047,7 @@ endif
>>   ifndef ASFLAGS
>>   ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS))
>>   endif
>> -ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)
>> +override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)
>>   
>>   ifndef BUILD_CC
>>   BUILD_CC = $(CC)  
>
>Ping?



More information about the Libc-alpha mailing list