[PATCH] Makeconfig (ASFLAGS): Always append required assembler flags

Florian Weimer fweimer@redhat.com
Tue Aug 14 15:57:00 GMT 2018


On 07/04/2018 04:29 PM, Florian Weimer wrote:
> Otherwise, it is impossible to set ASFLAGS differently from CFLAGS
> without also overriding essential flags such as -Wa,--noexecstack.
> 
> 2018-07-04  Florian Weimer  <fweimer@redhat.com>
> 
> 	* Makeconfig (ASFLAGS): Always append required assembler flags.
> 
> diff --git a/Makeconfig b/Makeconfig
> index 608ffe648c..099f184088 100644
> --- a/Makeconfig
> +++ b/Makeconfig
> @@ -1047,7 +1047,7 @@ endif
>   ifndef ASFLAGS
>   ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS))
>   endif
> -ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)
> +override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)
>   
>   ifndef BUILD_CC
>   BUILD_CC = $(CC)

Ping?

Thanks,
Florian



More information about the Libc-alpha mailing list