[PATCH] nscd: Deallocate existing user names in file parser

[Carlos O'Donell]

On 08/13/2018 02:33 PM, DJ Delorie wrote:
> 
> fweimer@redhat.com (Florian Weimer) writes:
>> -	    server_user = xstrdup (arg1);
>> +	    {
>> +	      free ((char *) server_user);
>> +	      server_user = xstrdup (arg1);
>> +	    }
> 
> server_user is global and unitialized, so initialized to NULL.  free()
> allows the passed pointer to be NULL.  So this is OK.
> 
> Note that free() nominally takes a void*, not a char*.  I think we
> should use void* in this case.
> 
>>  	    {
>> +	      free ((char *) stat_user);
>>  	      stat_user = xstrdup (arg1);
> 
> Same here.
> 

Does this mean you think the patch is OK as is?

Please remember to be clear about this.

My recommendation is to use "Reviewed-by: DJ Delorie <dj@redhat.com>" at the
end of your reviews to make the review clear.

-- 
Cheers,
Carlos.