[PATCH] nscd: Deallocate existing user names in file parser
DJ Delorie
dj@redhat.com
Mon Aug 13 18:33:00 GMT 2018
fweimer@redhat.com (Florian Weimer) writes:
> - server_user = xstrdup (arg1);
> + {
> + free ((char *) server_user);
> + server_user = xstrdup (arg1);
> + }
server_user is global and unitialized, so initialized to NULL. free()
allows the passed pointer to be NULL. So this is OK.
Note that free() nominally takes a void*, not a char*. I think we
should use void* in this case.
> {
> + free ((char *) stat_user);
> stat_user = xstrdup (arg1);
Same here.
More information about the Libc-alpha
mailing list