[PATCH] malloc: Perform full initialization before __malloc_check_init

Florian Weimer fweimer@redhat.com
Tue Sep 26 13:05:00 GMT 2017


On 09/20/2017 09:17 PM, DJ Delorie wrote:
> fweimer@redhat.com  (Florian Weimer) writes:
>> +      /* Perform full initialization.  */
>> +      malloc_consolidate (&main_arena);
> I'd like this comment to have more of a "why" component, so that future
> readers understand why we're "consolidating" in an initialization
> function, but otherwise the patch looks good to me.  Perhaps this?
> 
> /* Call this once to initialize the arenas as a side-effect. */

There is just one arena at this point, and maybe we should explain the 
concrete reason why this is needed.  What about the attached patch?

Thanks,
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: malloc-init.patch
Type: text/x-patch
Size: 1632 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170926/510d08aa/attachment.bin>


More information about the Libc-alpha mailing list