[PATCH] malloc: Perform full initialization before __malloc_check_init

DJ Delorie dj@redhat.com
Wed Sep 20 19:17:00 GMT 2017


fweimer@redhat.com (Florian Weimer) writes:
> +      /* Perform full initialization.  */
> +      malloc_consolidate (&main_arena);

I'd like this comment to have more of a "why" component, so that future
readers understand why we're "consolidating" in an initialization
function, but otherwise the patch looks good to me.  Perhaps this?

> /* Call this once to initialize the arenas as a side-effect. */

Alternatively, call the two functions that malloc_consolidate() calls:

    malloc_init_state(av);
    check_malloc_state(av);

(is the second really needed though?)



More information about the Libc-alpha mailing list