[PATCH] abort: Do not flush stdio streams [BZ #15436]

Florian Weimer fweimer@redhat.com
Thu Oct 5 10:48:00 GMT 2017


On 09/20/2017 11:30 PM, Carlos O'Donell wrote:
> On 09/18/2017 08:33 AM, Florian Weimer wrote:
>> On 08/30/2017 06:22 PM, Carlos O'Donell wrote:
>>> On 08/30/2017 10:52 AM, Florian Weimer wrote:
>>>> Here's an alternative patch which removes flushing completely.  This is
>>>> what Andreas suggested.
>>>>
>>>> I've added a short NEWS entry.
>>>
>>> Could you please also add a wiki note for
>>> https://sourceware.org/glibc/wiki/Release/2.27#Packaging_Changes
>>> which explains what happened and why?
>>
>> Do we have consensus for this patch?  I haven't pushed it yet.
> 
> I thought we did :-)
> 
> However, if you, the author of the patch, aren't sure, then it is certainly
> important to repost your patch and gather another round of review.
> 
> The key point is that we don't have to do this flushing if we don't have to
> and it's hard to see anyone claiming they needed these exact semantics given
> that abort() is an abnormal termination scenario.

There were no objections to the patch:

   <https://sourceware.org/ml/libc-alpha/2017-08/msg01304.html>

I'm going to commit it shortly and update the wiki as well.

Thanks,
Florian



More information about the Libc-alpha mailing list