Separate patch reviews for support/ additions?

Carlos O'Donell carlos@redhat.com
Fri Nov 3 21:57:00 GMT 2017


On 11/03/2017 02:54 PM, DJ Delorie wrote:
> Florian Weimer <fweimer@redhat.com> writes:
>> Do we want separate patch reviews for any new support/ functions?  Or 
>> should we just add them along with test cases that need them?
> 
> If the question is, "should we review new things in support/?" I think
> the answer is obviously yes.
> 
> But I assume the question is, "should they be reviewed separately, or
> bundled?"  I prefer bundled - we have a large enough patch backlog
> already without artificially increasing traffic.  Also, seeing the
> context might help with the review.  It would certainly short-circuit
> the "why do we need this?" questions ;-)
 
Agreed. I said this in my other email, but the context helps the review.

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list