Separate patch reviews for support/ additions?

DJ Delorie dj@redhat.com
Fri Nov 3 21:54:00 GMT 2017


Florian Weimer <fweimer@redhat.com> writes:
> Do we want separate patch reviews for any new support/ functions?  Or 
> should we just add them along with test cases that need them?

If the question is, "should we review new things in support/?" I think
the answer is obviously yes.

But I assume the question is, "should they be reviewed separately, or
bundled?"  I prefer bundled - we have a large enough patch backlog
already without artificially increasing traffic.  Also, seeing the
context might help with the review.  It would certainly short-circuit
the "why do we need this?" questions ;-)



More information about the Libc-alpha mailing list