[PATCH] x86: Don't include cacheinfo.c in ld.so

Siddhesh Poyarekar siddhesh@gotplt.org
Wed May 24 05:15:00 GMT 2017


On Wednesday 24 May 2017 08:43 AM, H.J. Lu wrote:
> Since cacheinfo.c isn't used by ld.so, there is no need to include it
> in ld.so.
> 
> Any comments.

Why is this necessary?  In what condition does cacheinfo.c get built
into ld.so?

Siddhesh

> H.J.
> ---
> 	* sysdeps/x86/cacheinfo.c: Skip if not in libc.
> ---
>  sysdeps/x86/cacheinfo.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c
> index 43c0b63..12ffeef 100644
> --- a/sysdeps/x86/cacheinfo.c
> +++ b/sysdeps/x86/cacheinfo.c
> @@ -16,6 +16,8 @@
>     License along with the GNU C Library; if not, see
>     <http://www.gnu.org/licenses/>.  */
>  
> +#if IS_IN (libc)
> +
>  #include <assert.h>
>  #include <stdbool.h>
>  #include <stdlib.h>
> @@ -769,3 +770,5 @@ intel_bug_no_cache_info:
>       store becomes faster.  */
>    __x86_shared_non_temporal_threshold = __x86_shared_cache_size * 6;
>  }
> +
> +#endif
> 



More information about the Libc-alpha mailing list