[PATCH v2] Fix test-errno issues
Adhemerval Zanella
adhemerval.zanella@linaro.org
Wed Mar 15 20:10:00 GMT 2017
On 15/03/2017 04:15, Mike Frysinger wrote:
> On 14 Mar 2017 17:26, Adhemerval Zanella wrote:
>> + if (ret == (rtype) -1 && (err == experr1 || err == experr2)) \
>
> not a new issue exactly, but should be parens around experr1 & experr2
>
>> + fail = 0; \
>> + else \
>> + { \
>> + fail = 1; \
>> + if (ret != (rtype) -1) \
>> + printf ("FAIL: " #syscall ": didn't fail as expected" \
>> + " (return "prtype")\n", ret); \
>
> shouldn't these be indented with tabs ?
>
>> + else if (err == 0xdead) \
>> + puts("FAIL: " #syscall ": didn't update errno\n"); \
>
> missing parens before the (
>
> don't need the \n since it's a puts
> -mike
I fixed the format issues and pushed as b36a65e5ca.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170315/451238f0/attachment.sig>
More information about the Libc-alpha
mailing list