[PATCH v2] Fix test-errno issues

Mike Frysinger vapier@gentoo.org
Wed Mar 15 07:17:00 GMT 2017


On 14 Mar 2017 17:26, Adhemerval Zanella wrote:
> +    if (ret == (rtype) -1 && (err == experr1 || err == experr2))	\

not a new issue exactly, but should be parens around experr1 & experr2

> +      fail = 0;								\
> +    else								\
> +      {									\
> +        fail = 1;							\
> +        if (ret != (rtype) -1)						\
> +          printf ("FAIL: " #syscall ": didn't fail as expected"		\
> +               " (return "prtype")\n", ret);				\

shouldn't these be indented with tabs ?

> +        else if (err == 0xdead)						\
> +          puts("FAIL: " #syscall ": didn't update errno\n");		\

missing parens before the (

don't need the \n since it's a puts
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170315/2a3a2c07/attachment.sig>


More information about the Libc-alpha mailing list