[PATCH] ld.so: Introduce struct dl_exception

[Florian Weimer]

On 06/20/2017 01:56 AM, Nix wrote:
> On 19 Jun 2017, Florian Weimer outgrape:
> 
>> +static void
>> +__attribute__ ((noreturn))
>> +length_mismatch (void)
>> +{
>> +  _dl_fatal_printf ("Fatal error: "
>> +                    "length accouting in _dl_exception_create_format\n");
>> +}
> 
> This is possibly the least useful review comment ever, but you probably
> meant 'accounting' here.

Not at all, fixed.

>> diff --git a/sysdeps/generic/localplt.data b/sysdeps/generic/localplt.data
>> index 81c741b..4664e0c 100644
>> --- a/sysdeps/generic/localplt.data
>> +++ b/sysdeps/generic/localplt.data
>> @@ -16,3 +16,5 @@ ld.so: free
>>  # The TLS-enabled version of these functions is interposed from libc.so.
>>  ld.so: _dl_signal_error
>>  ld.so: _dl_catch_error
>> +ld.so: _dl_signal_exception
>> +ld.so: _dl_catch_excetion
> 
> This typo (excetion for exception) is repeated in all the localplt
> datafiles.

Ugh, it conveniently was correct for the target I tested.  Also
corrected in the attached patch, which went through build-many-glibcs.py
this time, without any regressions I could see.

I plan to port over the remaining users of the old interface and remove
that, but this will change the dl/libc internal ABI and makes updates
more complicated (older glibcs have neither interface, though).

Thanks,
Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dl-exception.patch
Type: text/x-patch
Size: 46369 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170620/e0ae6037/attachment.bin>