[PATCH] ld.so: Introduce struct dl_exception

Nix nix@esperi.org.uk
Mon Jun 19 23:56:00 GMT 2017


On 19 Jun 2017, Florian Weimer outgrape:

> +static void
> +__attribute__ ((noreturn))
> +length_mismatch (void)
> +{
> +  _dl_fatal_printf ("Fatal error: "
> +                    "length accouting in _dl_exception_create_format\n");
> +}

This is possibly the least useful review comment ever, but you probably
meant 'accounting' here.

> diff --git a/sysdeps/generic/localplt.data b/sysdeps/generic/localplt.data
> index 81c741b..4664e0c 100644
> --- a/sysdeps/generic/localplt.data
> +++ b/sysdeps/generic/localplt.data
> @@ -16,3 +16,5 @@ ld.so: free
>  # The TLS-enabled version of these functions is interposed from libc.so.
>  ld.so: _dl_signal_error
>  ld.so: _dl_catch_error
> +ld.so: _dl_signal_exception
> +ld.so: _dl_catch_excetion

This typo (excetion for exception) is repeated in all the localplt
datafiles.

-- 
NULL && (void)



More information about the Libc-alpha mailing list