[PATCH] Enable hidden visibility in libc.a compiled with PIE

Florian Weimer fweimer@redhat.com
Mon Aug 21 15:52:00 GMT 2017


On 08/21/2017 05:48 PM, Florian Weimer wrote:
> On 08/08/2017 06:40 PM, H.J. Lu wrote:
>> -#if defined SHARED || defined LIBC_NONSHARED
>> +#if defined SHARED || defined LIBC_NONSHARED \
>> +  || (BUILD_PIE_DEFAULT && IS_IN (libc))
>>  # define attribute_hidden __attribute__ ((visibility ("hidden")))
>>  #else
>>  # define attribute_hidden
> 
> I think this broke “make subdirs=benchtests bench-build” because
> json-lib.c is erroneously compiled with -DMODULE_NAME=libc.

I think this fixes it.

Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: benchtests.patch
Type: text/x-patch
Size: 1144 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170821/dee8dede/attachment.bin>


More information about the Libc-alpha mailing list