[PATCH] Enable hidden visibility in libc.a compiled with PIE

Florian Weimer fweimer@redhat.com
Mon Aug 21 15:49:00 GMT 2017


On 08/08/2017 06:40 PM, H.J. Lu wrote:
> -#if defined SHARED || defined LIBC_NONSHARED
> +#if defined SHARED || defined LIBC_NONSHARED \
> +  || (BUILD_PIE_DEFAULT && IS_IN (libc))
>  # define attribute_hidden __attribute__ ((visibility ("hidden")))
>  #else
>  # define attribute_hidden

I think this broke “make subdirs=benchtests bench-build” because
json-lib.c is erroneously compiled with -DMODULE_NAME=libc.

Thanks,
Florian



More information about the Libc-alpha mailing list