[PATCH 1/3] Optimize trunc() and truncf().

[Joseph Myers]

On Wed, 25 May 2016, Mike Frysinger wrote:

> On 25 May 2016 15:36, Joseph Myers wrote:
> > On Tue, 24 May 2016, Matt Turner wrote:
> > > -  else
> > > -    {
> > > -      if (j0 == 0x400)
> > > -	/* x is inf or NaN.  */
> > > -	return x + x;
> > > -    }
> > 
> > You're removing too much code here.  You need to keep this addition in the 
> > NaN case to ensure that signaling NaNs raise "invalid" and get converted 
> > to quiet NaNs in the process.
> 
> does this mean current test coverage is insufficient ?

Yes.  I intend to add sNaN support to libm-test.inc at some point if noone 
else gets there first; no doubt this would then show up lots of bugs in 
existing code.  Cf. 
<https://sourceware.org/ml/libc-ports/2013-04/msg00008.html>, but that 
would need completely reworking now for current libm-test.

-- 
Joseph S. Myers
joseph@codesourcery.com