[PATCH] Fix memory leak in printf_positional
Paul Pluzhnikov
ppluzhnikov@google.com
Thu Sep 3 14:17:00 GMT 2015
On Thu, Sep 3, 2015 at 12:23 AM, Andreas Schwab <schwab@suse.de> wrote:
> Paul Pluzhnikov <ppluzhnikov@google.com> writes:
>> +$(objpfx)tst-printf-bz18872.c: tst-printf-bz18872.sh
>> + rm -f $@
>> + $(BASH) $^ > $@
>
> Please make that atomic by using a temporary file.
Sorry, I didn't understand that comment.
Do you mean that I should have a rule like this:
$(objpfx)tst-printf-bz18872.out: tst-printf-bz18872.sh
$(BASH) $^ | $(CC) ... -o $(objpfx)tst-printf-bz18872 -xc -
$(test-something-or-other)
or something else?
(Figuring out the commands for that rule gives me a pause.)
Thanks,
--
Paul Pluzhnikov
More information about the Libc-alpha
mailing list