[PATCH] Fix memory leak in printf_positional

Andreas Schwab schwab@suse.de
Thu Sep 3 14:39:00 GMT 2015


Paul Pluzhnikov <ppluzhnikov@google.com> writes:

> On Thu, Sep 3, 2015 at 12:23 AM, Andreas Schwab <schwab@suse.de> wrote:
>> Paul Pluzhnikov <ppluzhnikov@google.com> writes:
>
>>> +$(objpfx)tst-printf-bz18872.c: tst-printf-bz18872.sh
>>> +     rm -f $@
>>> +     $(BASH) $^ > $@
>>
>> Please make that atomic by using a temporary file.
>
> Sorry, I didn't understand that comment.

The target must always be either complete or absent.  A redirection is
not atomic.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



More information about the Libc-alpha mailing list