[PATCH][BZ 18234] struct stat is not posix conform

Szabolcs Nagy szabolcs.nagy@arm.com
Fri May 22 14:22:00 GMT 2015


On 21/05/15 17:23, Siddhesh Poyarekar wrote:
> On Thu, May 21, 2015 at 05:15:44PM +0100, Szabolcs Nagy wrote:
>> here is the patch with consistent __USE_XOPEN2K8
>>
>> ok to commit?
>>
>> 2015-05-21  Szabolcs Nagy  <szabolcs.nagy@arm.com>
>>
>> 	[BZ #18234]
>> 	* conform/data/sys/stat.h-data (struct stat): Add tests for st_atim,
>> 	st_mtim and st_ctim members.
>>
>> 	* sysdeps/nacl/bits/stat.h (struct stat, struct stat64): Make
>> 	st_atim, st_ctim, st_mtim visible under __USE_XOPEN2K8 only.
>>
>> 	* sysdeps/unix/sysv/linux/generic/bits/stat.h (struct stat,):
>> 	(struct stat64): Likewise.
>>
>> 	* sysdeps/unix/sysv/linux/ia64/bits/stat.h (struct stat,):
>> 	(struct stat64): Likewise.
>>
>> 	* sysdeps/unix/sysv/linux/microblaze/bits/stat.h (struct stat,):
>> 	(struct stat64): Likewise.
> 
> The Changelog entry lines should not have the extra newlines.  Looks
> fine to me other than that.  It doesn't look like you have commit
> access, so I'll commit it tomorrow for you.
> 

thanks, that would be nice.

changelog, without empty lines:

2015-05-22  Szabolcs Nagy  <szabolcs.nagy@arm.com>

 	[BZ #18234]
 	* conform/data/sys/stat.h-data (struct stat): Add tests for st_atim,
 	st_mtim and st_ctim members.
 	* sysdeps/nacl/bits/stat.h (struct stat, struct stat64): Make
 	st_atim, st_ctim, st_mtim visible under __USE_XOPEN2K8 only.
 	* sysdeps/unix/sysv/linux/generic/bits/stat.h (struct stat,):
 	(struct stat64): Likewise.
 	* sysdeps/unix/sysv/linux/ia64/bits/stat.h (struct stat,):
 	(struct stat64): Likewise.
 	* sysdeps/unix/sysv/linux/microblaze/bits/stat.h (struct stat,):
 	(struct stat64): Likewise.



More information about the Libc-alpha mailing list