[PATCH][BZ 18234] struct stat is not posix conform

[Carlos O'Donell]

On 05/21/2015 12:15 PM, Szabolcs Nagy wrote:
> On 21/05/15 05:29, Siddhesh Poyarekar wrote:
>> On Wed, May 20, 2015 at 06:55:02PM +0100, Szabolcs Nagy wrote:
>>> i guess it's ok for consistency if i fix struct stat64
>>> too to use __USE_XOPEN2K8.
>>>
>>> i will run some tests and come back with a patch
>>
>> I also think it would be appropriate to change this code in other
>> architectures (microblaze and nacl IIRC) to make all of them
>> consistent.  It is a mechanical enough change IMO that all arch
>> maintainer acks is not necessary.
>>
> 
> here is the patch with consistent __USE_XOPEN2K8
> 
> ok to commit?
> 
> 2015-05-21  Szabolcs Nagy  <szabolcs.nagy@arm.com>
> 
> 	[BZ #18234]
> 	* conform/data/sys/stat.h-data (struct stat): Add tests for st_atim,
> 	st_mtim and st_ctim members.
> 
> 	* sysdeps/nacl/bits/stat.h (struct stat, struct stat64): Make
> 	st_atim, st_ctim, st_mtim visible under __USE_XOPEN2K8 only.
> 
> 	* sysdeps/unix/sysv/linux/generic/bits/stat.h (struct stat,):
> 	(struct stat64): Likewise.
> 
> 	* sysdeps/unix/sysv/linux/ia64/bits/stat.h (struct stat,):
> 	(struct stat64): Likewise.
> 
> 	* sysdeps/unix/sysv/linux/microblaze/bits/stat.h (struct stat,):
> 	(struct stat64): Likewise.
> 

Modulo the ChangeLog problem pointed out by Siddhesh this also looks good to me.

Cheers,
Carlos.