[PATCH] powerpc: strstr optimization
Steven Munroe
munroesj@linux.vnet.ibm.com
Thu May 21 16:23:00 GMT 2015
On Thu, 2015-05-21 at 11:08 -0400, Carlos O'Donell wrote:
> On 05/12/2015 04:49 AM, OndÅej BÃlka wrote:
> >>> Following function should beat it.
> >>>
> >>> char *strstr (char *s, char *n)
> >>> {
> >>> if (n[0] == 0)
> >>> return s;
> >>> while (s = strchr (s, n[0]))
> >>> {
> >>> long i;
> >>> for (i=1; n[i] && n[i] == s[i]; i++);
> >>> if (n[i] == 0)
> >>> return s;
> >>> s++;
> >>> }
> >>> }
> >> Calling strchr in a loop is not showing improvement when compared
> >> to the proposed patch.
> >>>
> > Evidence?
> >
>
> I agree with Ondrej here. What tests are you doing to show there is
> no performance improvement? Can we see those tests? Can you contribute
> them to the microbenchmark so other Power vendors can use them against
> their particular hardware to validate performance?
>
I thought this was addressed with
https://www.sourceware.org/ml/libc-alpha/2015-05/msg00276.html
Which includes results from benchtest/bench-strstr.c.
Why do we need another micro-benchmark for this?
More information about the Libc-alpha
mailing list