[PATCH] powerpc: strstr optimization

Carlos O'Donell carlos@redhat.com
Thu May 21 16:10:00 GMT 2015


On 05/12/2015 04:49 AM, Ondřej Bílka wrote:
>>> Following function should beat it.
>>>
>>> char *strstr (char *s, char *n)
>>> {
>>>   if (n[0] == 0)
>>>     return s;
>>>   while (s = strchr (s, n[0]))
>>>     {
>>>       long i;
>>>       for (i=1; n[i] && n[i] == s[i]; i++);
>>>       if (n[i] == 0)
>>>         return s;
>>>       s++;
>>>     }
>>> }
>> Calling strchr in a loop is not showing  improvement when compared
>> to the proposed patch.
>>>
> Evidence?
> 

I agree with Ondrej here. What tests are you doing to show there is
no performance improvement? Can we see those tests? Can you contribute
them to the microbenchmark so other Power vendors can use them against
their particular hardware to validate performance?

Cheers,
Carlos.



More information about the Libc-alpha mailing list