[PATCH][V3][BZ #17833] _dl_close_worker() does not release inconsistent objects.

Pavel Kopyl p.kopyl@samsung.com
Tue Mar 3 09:14:00 GMT 2015


On 03/01/2015 10:17 PM, Mike Frysinger wrote:
> On 27 Feb 2015 16:32, Pavel Kopyl wrote:
>> --- /dev/null
>> +++ b/elf/tst-unique5lib.cc
>> @@ -0,0 +1,13 @@
>> +
> i know existing tests are bad examples, but lets try and start fixing that.
> namely, there should be a header here giving a quick overview of what it is
> exactly you're testing for, and a BZ reference.
>
>> +extern int not_exist ();
>> +
>> +inline int make_unique ()
>> +{
>> +  static int unique;
>> +  return ++unique;
>> +}
>> +
>> +int foo ()
>> +{
>> +  return make_unique () + not_exist ();
>> +}
> i don't know if this is just copy & pasting, but prototypes that do not intend
> to take args should always be (void).
> -mike

Thanks for review, I fixed that in patch v3.

Regards,
Pavel


-------------- next part --------------
A non-text attachment was scrubbed...
Name: delete_inconsistent_objs_v3.patch
Type: text/x-patch
Size: 6054 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20150303/784cdd26/attachment.bin>


More information about the Libc-alpha mailing list