[PATCH][V2][BZ #17833][PING] _dl_close_worker() does not release inconsistent objects.

Mike Frysinger vapier@gentoo.org
Sun Mar 1 19:17:00 GMT 2015


On 27 Feb 2015 16:32, Pavel Kopyl wrote:
> --- /dev/null
> +++ b/elf/tst-unique5lib.cc
> @@ -0,0 +1,13 @@
> +

i know existing tests are bad examples, but lets try and start fixing that.  
namely, there should be a header here giving a quick overview of what it is 
exactly you're testing for, and a BZ reference.

> +extern int not_exist ();
> +
> +inline int make_unique ()
> +{
> +  static int unique;
> +  return ++unique;
> +}
> +
> +int foo ()
> +{
> +  return make_unique () + not_exist ();
> +}

i don't know if this is just copy & pasting, but prototypes that do not intend 
to take args should always be (void).
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20150301/d8289a7d/attachment.sig>


More information about the Libc-alpha mailing list