Disable 64-bit atomics for MIPS n32 [committed]

H.J. Lu hjl.tools@gmail.com
Wed Jan 28 22:16:00 GMT 2015


On Wed, Jan 28, 2015 at 1:48 PM, Chris Metcalf <cmetcalf@ezchip.com> wrote:
> On 1/28/2015 4:31 PM, Torvald Riegel wrote:
>>
>> On Wed, 2015-01-28 at 18:45 +0000, Joseph Myers wrote:
>>>
>>> This patch disables use of 64-bit atomics for MIPS n32 to fix the
>>> problems with unaligned semaphores.
>>
>> That works.  I would probably preferred to just do this in the semaphore
>> bits (ie, checking for __HAVE_64B_ATOMICS and _LP64, but both have the
>> same effect for 2.21.
>
>
> You would then have disabled 64-bit atomics for x32, which may not
> be the solution preferred by H.J.
>

I am OK to disable 64-bit atomics in semaphore for x32 in 2.21. We can
look for a better solution in 2.22.  But the name, __HAVE_64B_ATOMICS,
is very much misleading.  How about

__HAVE_64B_ATOMICS_FOR_SEMAPHORE


-- 
H.J.



More information about the Libc-alpha mailing list