[PATCH v2] Clean up check_pf allocation pattern. addresses

[Ondřej Bílka]

On Wed, May 28, 2014 at 12:36:12PM +0200, Andreas Schwab wrote:
> Ondřej Bílka <neleai@seznam.cz> writes:
> 
> > @@ -137,20 +142,9 @@ make_request (int fd, pid_t pid)
> >  #else
> >    const size_t buf_size = __getpagesize ();
> >  #endif
> > -  bool use_malloc = false;
> >    char *buf;
> > -  size_t alloca_used = 0;
> >  
> > -  if (__libc_use_alloca (buf_size))
> > -    buf = alloca_account (buf_size, alloca_used);
> > -  else
> > -    {
> > -      buf = malloc (buf_size);
> > -      if (buf != NULL)
> > -	use_malloc = true;
> > -      else
> > -	goto out_fail;
> > -    }
> > +  buf = alloca (buf_size);
> 
> Does the compiler optimize this into a plain array if buf_size is
> constant?
> 
No, that would not be problem if gcc optimized alloca alignment which it
does not do now.