[PATCH v2] Clean up check_pf allocation pattern. addresses

Andreas Schwab schwab@suse.de
Wed May 28 10:58:00 GMT 2014


Ondřej Bílka <neleai@seznam.cz> writes:

> @@ -137,20 +142,9 @@ make_request (int fd, pid_t pid)
>  #else
>    const size_t buf_size = __getpagesize ();
>  #endif
> -  bool use_malloc = false;
>    char *buf;
> -  size_t alloca_used = 0;
>  
> -  if (__libc_use_alloca (buf_size))
> -    buf = alloca_account (buf_size, alloca_used);
> -  else
> -    {
> -      buf = malloc (buf_size);
> -      if (buf != NULL)
> -	use_malloc = true;
> -      else
> -	goto out_fail;
> -    }
> +  buf = alloca (buf_size);

Does the compiler optimize this into a plain array if buf_size is
constant?

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



More information about the Libc-alpha mailing list