[PATCH] Added missing ICMPv6 flags and option

Carlos O'Donell carlos@redhat.com
Wed Feb 12 20:25:00 GMT 2014


On 02/12/2014 02:31 PM, Dan Lüdtke wrote:
> Hi,
> 
> On Wed, Feb 12, 2014 at 8:13 PM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 02/12/2014 07:35 PM, Dan Luedtke wrote:
>>> +       * inet/netinet/icmp6.h: Added missing Router Advertisement Flags
>>> +       * inet/netinet/icmp6.h: Added ICMPv6 Recursive DNS Server Option
>> This entry does not follow the usual format.  You should list the
>> identifiers you changed.
> I did not change identifiers, did I? However, I have not contributed
> to glibc so I will read into how the community likes the ChangeLog
> best and change it according to the rules. Thanks for the hint.

https://sourceware.org/glibc/wiki/Contribution%20checklist

e.g.

	* inet/netinet/icmp6.h (FOO): Define.
	(FOO2): Likewise.
	...

I'll let Florian comment on the other points.

Cheers,
Carlos.



More information about the Libc-alpha mailing list