[PATCH] Added missing ICMPv6 flags and option

[Dan Lüdtke]

Hi,

On Wed, Feb 12, 2014 at 8:13 PM, Florian Weimer <fweimer@redhat.com> wrote:
> On 02/12/2014 07:35 PM, Dan Luedtke wrote:
>> +       * inet/netinet/icmp6.h: Added missing Router Advertisement Flags
>> +       * inet/netinet/icmp6.h: Added ICMPv6 Recursive DNS Server Option
> This entry does not follow the usual format.  You should list the
> identifiers you changed.
I did not change identifiers, did I? However, I have not contributed
to glibc so I will read into how the community likes the ChangeLog
best and change it according to the rules. Thanks for the hint.

>> +#define ND_RA_RTPREF_LOW         0x18
>> +#define ND_RA_RTPREF_MEDIUM      0x00
>> +#define ND_RA_RTPREF_HIGH        0x08
> This should reference RFC 4191.  Is there are source for names?
Where should the reference be? As I understand there is not a single
reference to a RFC in icmp6.h. Do you want me to reference this in the
ChangeLog file? Alternative names ND_RA_RTRPRF_LOW or
ND_RA_PREFERENCE_LOW. Further suggestions or sources?

>> +#define ND_RA_FLAG_PROXY         0x04
> RFC 4389, it appears.  Where does the name come from?
Inspired by the other names in icmp6.h, the RFC does not define a name
or I have not found it in there. Suggestions? I also like
ND_RA_FLAG_NDPROXY

Best,

Dan

On Wed, Feb 12, 2014 at 8:13 PM, Florian Weimer <fweimer@redhat.com> wrote:
> On 02/12/2014 07:35 PM, Dan Luedtke wrote:
>
>> +       * inet/netinet/icmp6.h: Added missing Router Advertisement Flags
>> +       * inet/netinet/icmp6.h: Added ICMPv6 Recursive DNS Server Option
>
>
> This entry does not follow the usual format.  You should list the
> identifiers you changed.
>
>
>> +#define ND_RA_RTPREF_LOW         0x18
>> +#define ND_RA_RTPREF_MEDIUM      0x00
>> +#define ND_RA_RTPREF_HIGH        0x08
>
>
> This should reference RFC 4191.  Is there are source for names?
>
>> +#define ND_RA_FLAG_PROXY         0x04
>
>
> RFC 4389, it appears.  Where does the name come from?
>
>
>> +#define ND_OPT_RDNSS                   25
>>
>>   struct nd_opt_prefix_info     /* prefix information */
>>     {
>> @@ -231,6 +236,15 @@ struct nd_opt_mtu             /* MTU option */
>>       uint32_t  nd_opt_mtu_mtu;
>>     };
>>
>> +struct nd_opt_rdnss           /* RDNSS option */
>> +  {
>> +    uint8_t   nd_opt_rdnss_type;
>> +    uint8_t   nd_opt_rdnss_len;
>> +    uint16_t  nd_opt_rdnss_reserved;
>> +    uint32_t  nd_opt_rdnss_lifetime;
>> +    /* followed by recursive DNS servers */
>> +  };
>
>
> This seems to come from RFC 5006.  The names appear to be somewhat standard.
>
> --
> Florian Weimer / Red Hat Product Security Team



-- 
Dan Luedtke
http://www.danrl.de