[Patch, MIPS] Fix warning in sysdeps/mips/dl-trampoline.c

Carlos O'Donell carlos@redhat.com
Thu Dec 11 16:46:00 GMT 2014


On 12/11/2014 11:21 AM, Steve Ellcey wrote:
> On Wed, 2014-12-10 at 20:01 -0500, Carlos O'Donell wrote:
> 
>> Why not "switch (l->l_info[VERSYMIDX (DT_VERSYM)] != NULL ? 0 : 1)" to
>> avoid the (int) case potentially hiding future type errors?
> 
> That seems reasonable but shouldn't it be "switch (l->l_info[VERSYMIDX
> (DT_VERSYM)] != NULL ? 1 : 0)"  I.e. return 1 if the boolean expression
> is true and 0 if the boolean expression is false?

Yes, you are correct, my mistake.

Cheers,
Carlos.



More information about the Libc-alpha mailing list