[Patch, MIPS] Fix warning in sysdeps/mips/dl-trampoline.c

Steve Ellcey sellcey@imgtec.com
Thu Dec 11 16:21:00 GMT 2014


On Wed, 2014-12-10 at 20:01 -0500, Carlos O'Donell wrote:

> Why not "switch (l->l_info[VERSYMIDX (DT_VERSYM)] != NULL ? 0 : 1)" to
> avoid the (int) case potentially hiding future type errors?

That seems reasonable but shouldn't it be "switch (l->l_info[VERSYMIDX
(DT_VERSYM)] != NULL ? 1 : 0)"  I.e. return 1 if the boolean expression
is true and 0 if the boolean expression is false?

Steve



More information about the Libc-alpha mailing list