[PATCH][BZ #15533] Avoid unnecessary slowdown from profiling with audit

Roland McGrath roland@hack.frob.com
Wed Sep 25 21:41:00 GMT 2013


> 'n' here is the number of loaded audit libraries, which is zero in normal
> use, and is very unlikely to exceed one as far as I can imagine.

That is true.

> The other audit callbacks are not invoked repeatedly over the process'
> lifetime, and correspond to places where the dynamic linker has to do
> work anyhow.  I wouldn't call optimizing those loops worthwhile.

It wouldn't be if it were hard.  But it's trivial.

> In my eyes your arguments against the patch look like the proverbial "making
> the perfect the enemy of the good".  

Proverbs are context-free.  Here we have a concrete "better" that is a
known, and small, amount of work.

> I don't volunteer to implement what you called "a better solution".

I don't approve the patch you sent.  Perhaps Ondrej or someone else will
take up the small amount of work necessary to get the change into an
acceptable form.  If you don't care about the change enough to spend
another half an hour implementing what I described, then you are clearly
not in any hurry to see it done.


Thanks,
Roland



More information about the Libc-alpha mailing list