[PATCH][BZ #15533] Avoid unnecessary slowdown from profiling with audit

Alexander Monakov amonakov@ispras.ru
Wed Sep 25 21:13:00 GMT 2013



On Wed, 25 Sep 2013, Roland McGrath wrote:

> I don't like the O(n) check on every _dl_relocate_object.

'n' here is the number of loaded audit libraries, which is zero in normal use,
and is very unlikely to exceed one as far as I can imagine.

The other audit callbacks are not invoked repeatedly over the process'
lifetime, and correspond to places where the dynamic linker has to do
work anyhow.  I wouldn't call optimizing those loops worthwhile.

In my eyes your arguments against the patch look like the proverbial "making
the perfect the enemy of the good".  I don't volunteer to implement what you
called "a better solution".

Alexander



More information about the Libc-alpha mailing list