[PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA

Roland McGrath roland@hack.frob.com
Tue May 28 23:15:00 GMT 2013


> On Tuesday 28 May 2013 15:32:51 Carlos O'Donell wrote:
> > On 05/25/2013 02:41 PM, Mike Frysinger wrote:
> > > +#define PTR_ALIGN_UP(base, size) \
> > > +  (void *) ALIGN_UP ((uintptr_t) (base), (size))
> > 
> > Almost done.
> > 
> > We install cdefs.h and thus these macros need __ to avoid being
> > in the user's namespace.
> 
> not exactly.  i picked include/sys/cdefs.h instead of misc/sys/cdefs.h because 
> the latter is for installing while the former is for internal use.

I don't think you should use include/sys/cdefs.h for that sort of purpose.
If it's internal-only stuff that doesn't directly relate to something else
that's in the API of an installed header, then do it purely in a private
header.



More information about the Libc-alpha mailing list