[PATCH v2] [BZ #10283] localedef: align fixed maps to SHMLBA

Carlos O'Donell carlos@redhat.com
Tue May 28 22:38:00 GMT 2013


On 05/28/2013 06:05 PM, Mike Frysinger wrote:
> On Tuesday 28 May 2013 15:32:51 Carlos O'Donell wrote:
>> On 05/25/2013 02:41 PM, Mike Frysinger wrote:
>>> +#define PTR_ALIGN_UP(base, size) \
>>> +  (void *) ALIGN_UP ((uintptr_t) (base), (size))
>>
>> Almost done.
>>
>> We install cdefs.h and thus these macros need __ to avoid being
>> in the user's namespace.
> 
> not exactly.  i picked include/sys/cdefs.h instead of misc/sys/cdefs.h because 
> the latter is for installing while the former is for internal use.

My mistake.
 
>> The benefit is that we'll be able to use them *everywhere*,
>> even in macros in headers we expose to userspace, which
>> is what we want.
> 
> i'm not sure.  maybe wait for such consumers to show up before we export ?

Agreed. I'm fine with that.

Cheers,
Carlos.



More information about the Libc-alpha mailing list