[PATCH v2][BZ #12685] Allow arbitrary number of modes in fopen.

[Andreas Schwab]

Ondřej Bílka <neleai@seznam.cz> writes:

> On Tue, May 14, 2013 at 02:31:14PM +0200, Andreas Schwab wrote:
>> Ondřej Bílka <neleai@seznam.cz> writes:
>> 
>> > diff --git a/libio/fileops.c b/libio/fileops.c
>> > index 61b61b3..50c3eb2 100644
>> > --- a/libio/fileops.c
>> > +++ b/libio/fileops.c
>> > @@ -286,12 +286,10 @@ _IO_new_file_fopen (fp, filename, mode, is32not64)
>> >  #ifdef _LIBC
>> >    last_recognized = mode;
>> >  #endif
>> > -  for (i = 1; i < 7; ++i)
>> > +  while (*mode && *mode != ',')
>> >      {
>> >        switch (*++mode)
>> 
>> That reads mode[1], but the loop conditions tests mode[0].
>> 
> This is still valid, to preserve original control flow.

But useless, since '\0' and ',' are processed before being tested for.
You should increment in the loop condition.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."