[PATCH v2][BZ #12685] Allow arbitrary number of modes in fopen.

Ondřej Bílka neleai@seznam.cz
Tue May 14 12:44:00 GMT 2013


On Tue, May 14, 2013 at 02:31:14PM +0200, Andreas Schwab wrote:
> Ondřej Bílka <neleai@seznam.cz> writes:
> 
> > diff --git a/libio/fileops.c b/libio/fileops.c
> > index 61b61b3..50c3eb2 100644
> > --- a/libio/fileops.c
> > +++ b/libio/fileops.c
> > @@ -286,12 +286,10 @@ _IO_new_file_fopen (fp, filename, mode, is32not64)
> >  #ifdef _LIBC
> >    last_recognized = mode;
> >  #endif
> > -  for (i = 1; i < 7; ++i)
> > +  while (*mode && *mode != ',')
> >      {
> >        switch (*++mode)
> 
> That reads mode[1], but the loop conditions tests mode[0].
> 
This is still valid, to preserve original control flow.



More information about the Libc-alpha mailing list